Skip to content

Comments

Merge release/26.4 into trunk#22390

Merged
crazytonyli merged 11 commits intotrunkfrom
merge/release-26.4-into-trunk
Dec 4, 2025
Merged

Merge release/26.4 into trunk#22390
crazytonyli merged 11 commits intotrunkfrom
merge/release-26.4-into-trunk

Conversation

@wpmobilebot
Copy link
Contributor

Merging release/26.4 into trunk.

Via intermediate branch merge/release-26.4-into-trunk, to help fix conflicts if any:

                            release/26.4  ----o-- - - -
                                               \
           merge/release-26.4-into-trunk        `---.
                                                     \
                                   trunk  ------------x- - -

@wpmobilebot wpmobilebot added the Releases Label related to managing releases label Dec 3, 2025
@wpmobilebot wpmobilebot added this to the 26.5 milestone Dec 3, 2025
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR has the Releases label: some checks will be skipped.

Generated by 🚫 Danger

context.startActivity(intent);
}

public static void viewReaderDiscoverInNewStack(Context context) {

Check notice

Code scanning / Android Lint

Nullable/NonNull annotation missing on method parameter Note

Missing null annotation
@wpmobilebot
Copy link
Contributor Author

wpmobilebot commented Dec 3, 2025

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
FlavorJalapeno
Build TypeDebug
Versionpr22390-5f80cc5
Commit5f80cc5
Direct Downloadwordpress-prototype-build-pr22390-5f80cc5.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor Author

wpmobilebot commented Dec 3, 2025

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
FlavorJalapeno
Build TypeDebug
Versionpr22390-5f80cc5
Commit5f80cc5
Direct Downloadjetpack-prototype-build-pr22390-5f80cc5.apk
Note: Google Login is not supported on these builds.

wpmobilebot and others added 10 commits December 4, 2025 10:48
* Add editorialized release notes for 26.4

* Update WordPress `PlayStoreStrings.po` for version 26.4

* Update Jetpack `PlayStoreStrings.po` for version 26.4

---------

Co-authored-by: Tony Li <tony.li@automattic.com>
* Adding a loading spinner to the recommended blogs subscribe button

* Fixing the loading wrong state

* Fixing it for the post details screen

* Fixing blog screen subscription as well

* detekt

* lint fix

* Using suspend function to iterate over cards

* Removing the withContext, but keeping the scope usage

* Some refactoring

* Adding tests

* Update WordPress/src/main/java/org/wordpress/android/ui/reader/views/ReaderSiteHeaderView.java

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

* Compile fix

* chore: trigger CI

---------

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
* Supporting read and discovery deeplinks

* Fixing discovery issue

* Handling feed links

* Handling search and tags

* Some improvements

* Re-adding deleted code

* Lint fixes

* Adding tests for ReaderActivityLauncher

* Update WordPress/src/main/java/org/wordpress/android/ui/ActivityLauncher.java

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

* chore: trigger CI

* Supporting the new Calypso banner specs

* Adding some tests

---------

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
* Update editorial release notes

* Update WordPress `PlayStoreStrings.po` for version 26.4

* Update Jetpack `PlayStoreStrings.po` for version 26.4

---------

Co-authored-by: Tony Li <tony.li@automattic.com>
@crazytonyli crazytonyli force-pushed the merge/release-26.4-into-trunk branch from 160ad80 to 0d85daa Compare December 3, 2025 21:58
@crazytonyli
Copy link
Contributor

This PR merges the tag 26.4-rc-3 into the trunk branch. I attempted to resolve the merge conflicts. @adalpari can you please review the changes to see if I resolved the conflicts correctly? Feel free to make additional changes to this PR.

@crazytonyli crazytonyli requested a review from adalpari December 3, 2025 21:58
@crazytonyli crazytonyli closed this Dec 3, 2025
@crazytonyli crazytonyli reopened this Dec 3, 2025
@wpmobilebot
Copy link
Contributor Author

wpmobilebot commented Dec 4, 2025

Project manifest changes for WordPress

The following changes in the WordPress's merged AndroidManifest.xml file were detected (build variant: wordpressVanillaRelease):

--- ./build/reports/diff_manifest/WordPress/wordpressVanillaRelease/base_manifest.txt	2025-12-04 02:52:57.385350069 +0000
+++ ./build/reports/diff_manifest/WordPress/wordpressVanillaRelease/head_manifest.txt	2025-12-04 02:53:04.825389416 +0000
@@ -2,8 +2,8 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="org.wordpress.android"
     android:installLocation="auto"
-    android:versionCode="1479"
-    android:versionName="26.4-rc-1" >
+    android:versionCode="1481"
+    android:versionName="26.4-rc-3" >
 
     <uses-sdk
         android:minSdkVersion="26"
@@ -596,6 +596,62 @@
                     android:host="wordpress.com"
                     android:pathPattern="/site-monitoring/.*"
                     android:scheme="http" />
+                <data
+                    android:host="wordpress.com"
+                    android:path="/read"
+                    android:scheme="https" />
+                <data
+                    android:host="wordpress.com"
+                    android:path="/read"
+                    android:scheme="http" />
+                <data
+                    android:host="wordpress.com"
+                    android:path="/discover"
+                    android:scheme="https" />
+                <data
+                    android:host="wordpress.com"
+                    android:path="/discover"
+                    android:scheme="http" />
+                <data
+                    android:host="wordpress.com"
+                    android:pathPattern="/read/feeds/.*"
+                    android:scheme="https" />
+                <data
+                    android:host="wordpress.com"
+                    android:pathPattern="/read/feeds/.*"
+                    android:scheme="http" />
+                <data
+                    android:host="wordpress.com"
+                    android:pathPattern="/reader/feeds/.*"
+                    android:scheme="https" />
+                <data
+                    android:host="wordpress.com"
+                    android:pathPattern="/reader/feeds/.*"
+                    android:scheme="http" />
+                <data
+                    android:host="wordpress.com"
+                    android:path="/read/search"
+                    android:scheme="https" />
+                <data
+                    android:host="wordpress.com"
+                    android:path="/read/search"
+                    android:scheme="http" />
+                <data
+                    android:host="wordpress.com"
+                    android:path="/reader/search"
+                    android:scheme="https" />
+                <data
+                    android:host="wordpress.com"
+                    android:path="/reader/search"
+                    android:scheme="http" />
+                <data
+                    android:host="wordpress.com"
+                    android:pathPattern="/tag/.*"
+                    android:scheme="https" />
+                <data
+                    android:host="wordpress.com"
+                    android:pathPattern="/tag/.*"
+                    android:scheme="http" />
             </intent-filter>
         </activity-alias> <!-- Custom Wordpress URI Scheme Deep Linking Activity Alias -->
         <activity-alias
@@ -683,6 +739,16 @@
                     android:scheme="http" >
                 </data>
                 <data
+                    android:host="wordpress.com"
+                    android:pathPattern="/reader/feeds/.*/posts/.*"
+                    android:scheme="https" >
+                </data>
+                <data
+                    android:host="wordpress.com"
+                    android:pathPattern="/reader/feeds/.*/posts/.*"
+                    android:scheme="http" >
+                </data>
+                <data
                     android:host="wordpress.com"
                     android:pathPattern="/reader/feeds/.*/posts/.*"
                     android:scheme="https" >

Go to https://buildkite.com/automattic/wordpress-android/builds/24092/canvas?sid=019ae742-319c-4dd3-8924-ca15b4d2b273, click on the Artifacts tab and audit the files.

@wpmobilebot
Copy link
Contributor Author

wpmobilebot commented Dec 4, 2025

Project manifest changes for WordPress

The following changes in the WordPress's merged AndroidManifest.xml file were detected (build variant: jetpackVanillaRelease):

--- ./build/reports/diff_manifest/WordPress/jetpackVanillaRelease/base_manifest.txt	2025-12-04 02:52:44.277599865 +0000
+++ ./build/reports/diff_manifest/WordPress/jetpackVanillaRelease/head_manifest.txt	2025-12-04 02:52:51.267610737 +0000
@@ -2,8 +2,8 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="com.jetpack.android"
     android:installLocation="auto"
-    android:versionCode="1479"
-    android:versionName="26.4-rc-1" >
+    android:versionCode="1481"
+    android:versionName="26.4-rc-3" >
 
     <uses-sdk
         android:minSdkVersion="26"
@@ -233,6 +233,62 @@
                     android:host="wordpress.com"
                     android:pathPattern="/site-monitoring/.*"
                     android:scheme="http" />
+                <data
+                    android:host="wordpress.com"
+                    android:path="/read"
+                    android:scheme="https" />
+                <data
+                    android:host="wordpress.com"
+                    android:path="/read"
+                    android:scheme="http" />
+                <data
+                    android:host="wordpress.com"
+                    android:path="/discover"
+                    android:scheme="https" />
+                <data
+                    android:host="wordpress.com"
+                    android:path="/discover"
+                    android:scheme="http" />
+                <data
+                    android:host="wordpress.com"
+                    android:pathPattern="/read/feeds/.*"
+                    android:scheme="https" />
+                <data
+                    android:host="wordpress.com"
+                    android:pathPattern="/read/feeds/.*"
+                    android:scheme="http" />
+                <data
+                    android:host="wordpress.com"
+                    android:pathPattern="/reader/feeds/.*"
+                    android:scheme="https" />
+                <data
+                    android:host="wordpress.com"
+                    android:pathPattern="/reader/feeds/.*"
+                    android:scheme="http" />
+                <data
+                    android:host="wordpress.com"
+                    android:path="/read/search"
+                    android:scheme="https" />
+                <data
+                    android:host="wordpress.com"
+                    android:path="/read/search"
+                    android:scheme="http" />
+                <data
+                    android:host="wordpress.com"
+                    android:path="/reader/search"
+                    android:scheme="https" />
+                <data
+                    android:host="wordpress.com"
+                    android:path="/reader/search"
+                    android:scheme="http" />
+                <data
+                    android:host="wordpress.com"
+                    android:pathPattern="/tag/.*"
+                    android:scheme="https" />
+                <data
+                    android:host="wordpress.com"
+                    android:pathPattern="/tag/.*"
+                    android:scheme="http" />
             </intent-filter>
         </activity-alias> <!-- Custom Wordpress URI Scheme Deep Linking Activity Alias -->
         <activity-alias
@@ -710,6 +766,16 @@
                     android:scheme="http" >
                 </data>
                 <data
+                    android:host="wordpress.com"
+                    android:pathPattern="/reader/feeds/.*/posts/.*"
+                    android:scheme="https" >
+                </data>
+                <data
+                    android:host="wordpress.com"
+                    android:pathPattern="/reader/feeds/.*/posts/.*"
+                    android:scheme="http" >
+                </data>
+                <data
                     android:host="wordpress.com"
                     android:pathPattern="/reader/feeds/.*/posts/.*"
                     android:scheme="https" >

Go to https://buildkite.com/automattic/wordpress-android/builds/24092/canvas?sid=019ae742-319c-4b73-a840-d9be17a7ad0a, click on the Artifacts tab and audit the files.

@crazytonyli crazytonyli force-pushed the merge/release-26.4-into-trunk branch from 0682739 to 5f80cc5 Compare December 4, 2025 02:47
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2025

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 61.53846% with 70 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.11%. Comparing base (9b5ab17) to head (5f80cc5).
⚠️ Report is 4 commits behind head on trunk.

Files with missing lines Patch % Lines
...ava/org/wordpress/android/ui/ActivityLauncher.java 0.00% 25 Missing ⚠️
...ss/android/ui/reader/viewmodels/ReaderViewModel.kt 5.55% 16 Missing and 1 partial ⚠️
...android/ui/deeplinks/handlers/ReaderLinkHandler.kt 86.95% 4 Missing and 5 partials ⚠️
...droid/ui/reader/repository/ReaderPostRepository.kt 0.00% 7 Missing ⚠️
...ordpress/android/ui/deeplinks/DeepLinkNavigator.kt 50.00% 4 Missing ⚠️
...roid/ui/reader/discover/ReaderDiscoverViewModel.kt 82.60% 1 Missing and 3 partials ⚠️
...ress/android/ui/reader/views/ReaderFollowButton.kt 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #22390      +/-   ##
==========================================
+ Coverage   39.02%   39.11%   +0.08%     
==========================================
  Files        2203     2203              
  Lines      106348   106493     +145     
  Branches    15061    15118      +57     
==========================================
+ Hits        41501    41650     +149     
+ Misses      61356    61334      -22     
- Partials     3491     3509      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@adalpari adalpari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crazytonyli crazytonyli merged commit 5385671 into trunk Dec 4, 2025
23 checks passed
@crazytonyli crazytonyli deleted the merge/release-26.4-into-trunk branch December 4, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Releases Label related to managing releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants